https://bugzilla.redhat.com/show_bug.cgi?id=2328647 --- Comment #3 from Uri Lublin <uril@xxxxxxxxxx> --- Vitaly, thank you for reviewing. (In reply to Vitaly Kuznetsov from comment #2) > - Why do we use 'trustee-attester' name for the source package? Upstream > this is part of 'Confidential Container Tools and Components' so even if we > don't package other tools from this collection now, they may come handy > afterwards. Would it rather make sense to name the source package e.g. > 'coco-guest-components'? That's a good point. I was thinking about it too. Currently the project does not publish crates on crates.io. When that happens the number of crates may change - for example, there may be only 1 'dep' crate instead of 3. Possibly trustee-attester will get its own crate in the future. > > - Where does the manpage come from? Assuming it was written from scratch for > Fedora, would it rather make sense to submit it upstream so it doesn't > diverge when code changes? It was written from scratch for Fedora. I'll send it upstream too. > Nitpick: I would suggest to not hardcode '.gz' for the manpage compression > as these things tend to change. I'd rather do > > %{_mandir}/man1/trustee-attester.1* I'll do that. > > - It is a bit weird that the actual program comes from a patch > (0001-Add-trustee-attester-a-simple-tool-to-fetch-secrets-.patch), this is > fragile as it may stop building/working with upstream code changes. Any > chance it can be pushed upstream? It is a bit weird. It's already pushed upstream, but not in release 0.10.0. I can create a tarball based on 'main' (and git describe), instead of 'v0.10.0' -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2328647 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328647%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
