https://bugzilla.redhat.com/show_bug.cgi?id=2328647 Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vkuznets@xxxxxxxxxx --- Comment #2 from Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> --- Just a few comments: - Why do we use 'trustee-attester' name for the source package? Upstream this is part of 'Confidential Container Tools and Components' so even if we don't package other tools from this collection now, they may come handy afterwards. Would it rather make sense to name the source package e.g. 'coco-guest-components'? - Where does the manpage come from? Assuming it was written from scratch for Fedora, would it rather make sense to submit it upstream so it doesn't diverge when code changes? Nitpick: I would suggest to not hardcode '.gz' for the manpage compression as these things tend to change. I'd rather do %{_mandir}/man1/trustee-attester.1* - It is a bit weird that the actual program comes from a patch (0001-Add-trustee-attester-a-simple-tool-to-fetch-secrets-.patch), this is fragile as it may stop building/working with upstream code changes. Any chance it can be pushed upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328647 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328647%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
