https://bugzilla.redhat.com/show_bug.cgi?id=2321925 --- Comment #11 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to Benson Muite from comment #10) > b) Consider changing: > Source0: > https://github.com/icl-utk-edu/heffte/archive/v%{version}.tar.gz#/%{name}- > %{version}.tar.gz > to > Source: > https://github.com/icl-utk-edu/heffte/archive/v%{version}/%{name}-%{version}. > tar.gz > as sources do not need to be numbered and the url follows suggested format > in the packaging guidelines: Done > c) Please ensure > /usr/include/mpich-x86_64/stock_fft > /usr/include/openmpi-x86_64/stock_fft > are owned, use Done > d) Is the testing configuration needed? It is installed by: > https://github.com/icl-utk-edu/heffte/blob/master/CMakeLists.txt#L328-L337 I deleted them > The resulting directories > /usr/share/heffte/testing > /usr/share/heffte > are not currently owned. Done > e) Can documentation be built? Current configuration is for HTML > documentation: > https://github.com/icl-utk-edu/heffte/blob/master/doxygen/CMakeLists.txt > though Doxygen can generate man pages. Added > f) Please capitalize summaries Fixed Spec URL: https://junghans.fedorapeople.org/heffte.spec SRPM URL: https://junghans.fedorapeople.org/heffte-2.4.1-2.fc42.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2321925 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202321925%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
