Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming zone https://bugzilla.redhat.com/show_bug.cgi?id=430360 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-02-03 14:24 EST ------- I recently became aware of a fix for the unused-direct-shlib-dependency complaints; you can put this after the %configure call: # hack to omit unused-direct-shlib-dependencies sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool and the problematic dependencies go away. It's not a huge issue but it's easy to fix, so do what you think is best. With that fix, the only other rpmlint complaint is: ggz-gtk-client-devel.x86_64: W: no-documentation which is not a problem. * source files match upstream: 790f7db17e252e02c07f68cbdda3de071945e284582edd1c5b21891e568c6cff ggz-gtk-client-0.0.14.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: ggz-gtk-client-0.0.14-2.fc9.x86_64.rpm libggz-gtk.so.1()(64bit) ggz-gtk-client = 0.0.14-2.fc9 = /sbin/ldconfig libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libggz-gtk.so.1()(64bit) libggz.so.2()(64bit) libggzcore.so.9()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) ggz-gtk-client-devel-0.0.14-2.fc9.x86_64.rpm ggz-gtk-client-devel = 0.0.14-2.fc9 = ggz-client-libs-devel ggz-gtk-client = 0.0.14-2.fc9 gtk2-devel libggz-devel libggz-gtk.so.1()(64bit) * %check is not; no test suite upstream. * shared libraries installed; ldconfig is called properly. * unversioned .so files are in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (ldconfig) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review