[Bug 2317848] Review Request: muon - C implementation of meson

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2317848



--- Comment #9 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Thanks for the feedback.

> 1. Rpmlint insists that licensing breakdown must be provided. Honestly I don't see it as a blocker but looks like 

> * forked samurai, tinyjson, and memmem.c are licensed under MIT
> * sha_256 is under Unlicense
> * the rest of source code is under GPLv3
> * tests artifacts are either under ASL 2.0 or not specified

Added license breakdown. Test artifacts are not included in built and installed
code.

> 2. Also please find out why these two tests are failing. I'd have a meson drop-in replacement which passes all the tests.\

Excluded tests that fail because of different build flags in Fedora to those
used in the tests.
These tests pass under normal build conditions.

> 3. Adjust whitespaces/tabs. Remove double whitespaces. A cosmetic issue, not a big deal.

Improved formatting.

In addition excluded conflicting documentation man page file from meson.

spec:
https://download.copr.fedorainfracloud.org/results/fed500/muon/fedora-rawhide-x86_64/08226358-muon-meson/muon-meson.spec
srpm:
https://download.copr.fedorainfracloud.org/results/fed500/muon/fedora-rawhide-x86_64/08226358-muon-meson/muon-meson-0.3.1%5E20240926.a2f0f77e-1.fc42.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2317848

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317848%23c9

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux