https://bugzilla.redhat.com/show_bug.cgi?id=2317848 Clemens Lang <cllang@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cllang@xxxxxxxxxx --- Comment #8 from Clemens Lang <cllang@xxxxxxxxxx> --- I see one test failure only: fail 0.89s project+meson-tests:meson-tests/common/223 persubproject options stderr: '/builddir/build/BUILD/muon-0.3.1-build/muon-0.3.1/tests/project/runner.meson:69:1: error command failed 69 | run_command(ninja.split(' '), '-C', build, check: true) ^______________________________________________________ stdout: [1/14] compiling c subprojects/sub2/liblib1.so.p/foo.c.o [2/14] compiling c subprojects/sub2/liblib1.a.p/foo.c.o [3/14] compiling c subprojects/sub1/liblib1.a.p/foo.c.o [4/14] compiling cpp subprojects/sub2/liblib2.a.p/foo.cpp.o [5/14] compiling cpp test1.p/main.cpp.o [6/14] compiling c liblib1.a.p/foo.c.o ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub2/foo.c:4:2: warning: #warning before C23 is a GCC extension 4 | #warning This should not produce error | ^~~~~~~ ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub2/foo.c:4:2: warning: #warning This should not produce error [-Wcpp] [7/14] linking static subprojects/sub2/liblib1.a [8/14] linking liblib1.so [9/14] linking static liblib1.a ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub1/foo.c: In function ‘foo’: ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub1/foo.c:6:7: error: unused variable ‘x’ [-Werror=unused-variable] 6 | int x; | ^ cc1: all warnings being treated as errors ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub2/foo.c:4:2: warning: #warning before C23 is a GCC extension 4 | #warning This should not produce error | ^~~~~~~ ../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub2/foo.c:4:2: warning: #warning This should not produce error [-Wcpp] stderr: samu: job failed with status 1: gcc -g -Og -Werror -fdiagnostics-color=always -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCX X_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer -m no-omit-leaf-frame-pointer -I subprojects/sub1 -I '../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub1' -fpic -MD -MQ subprojects/sub1/liblib1.a.p/foo.c.o -MF subprojects/sub1/liblib1.a.p/foo.c.o.d -o subprojects/sub1/liblib1.a.p/foo.c.o -c '../../../../../../tests/project/meson-tests/common/223 persubproject options/subprojects/sub1/foo.c' samu: subcommand failed /builddir/build/BUILD/muon-0.3.1-build/muon-0.3.1/tests/project/runner.meson:69:1: error in function run_command 69 | run_command(ninja.split(' '), '-C', build, check: true) ^______________________________________________________ ' The test is supposed to check that "223 persubproject options/subprojects/sub1/foo.c" compiles because the subproject resets the warning_level variable to 0. According to https://mesonbuild.com/Builtin-options.html, 0 means "compiler default", and chances are that compiler default in a fedora package build is not what muon expects it to be. In fact, when I finish the build of muon, install it in a container, and attempt to run the same test, it passes: [root@9b65fcf175ca 223 persubproject options]# muon setup builddir detected compiler gcc '14.2.1' (['cc']), linker: ld (['ld']), static_linker: ar (['ar']) detected compiler gcc '14.2.1' (['c++']), linker: ld (['ld']), static_linker: ar (['ar']) configuring 'persubproject options', version: undefined [sub1] entering subproject 'sub1' [sub1] detected compiler gcc '14.2.1' (['cc']), linker: ld (['ld']), static_linker: ar (['ar']) [sub1] detected compiler gcc '14.2.1' (['c++']), linker: ld (['ld']), static_linker: ar (['ar']) [sub1] configuring 'sub1', version: undefined [sub2] entering subproject 'sub2' [sub2] detected compiler gcc '14.2.1' (['cc']), linker: ld (['ld']), static_linker: ar (['ar']) [sub2] detected compiler gcc '14.2.1' (['c++']), linker: ld (['ld']), static_linker: ar (['ar']) [sub2] configuring 'sub2', version: undefined found dependency 'libcpp14' (declared dependency) version undefined static setup complete [root@9b65fcf175ca 223 persubproject options]# (cd builddir && ninja) [4/14] compiling c subprojects/sub2/liblib1.a.p/foo.c.o ../subprojects/sub2/foo.c:4:2: warning: #warning before C23 is a GCC extension 4 | #warning This should not produce error | ^~~~~~~ ../subprojects/sub2/foo.c:4:2: warning: #warning This should not produce error [-Wcpp] [5/14] compiling c subprojects/sub2/liblib1.so.p/foo.c.o ../subprojects/sub2/foo.c:4:2: warning: #warning before C23 is a GCC extension 4 | #warning This should not produce error | ^~~~~~~ ../subprojects/sub2/foo.c:4:2: warning: #warning This should not produce error [-Wcpp] [14/14] linking test1 The failing test is thus likely a false positive. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2317848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317848%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
