https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #20 from Kalev Lember <klember@xxxxxxxxxx> --- I wonder if you could let someone who is more familiar with rust packaging to review it instead? I don't find the back and forth here particularly helpful - I'm basically having to defend rust packaging best practices. As for updating to 47.0, there's a new build error when I try to build it: ``` error[E0599]: the method `set` exists for struct `RefCell<Option<DocumentModel>>`, but its trait bounds were not satisfied --> src/sidebar.rs:104:24 | 104 | self.model.set(Some(model)); | ^^^ | = note: the following trait bounds were not satisfied: `std::cell::RefCell<std::option::Option<papers_view::DocumentModel>>: glib::object::IsA<gio::Settings>` which is required by `std::cell::RefCell<std::option::Option<papers_view::DocumentModel>>: gdk4::prelude::SettingsExtManual` = help: items from traits can only be used if the trait is in scope help: trait `PropertySet` which provides `set` is implemented but not in scope; perhaps you want to import it | 4 + use glib::property::PropertySet; | ``` If anyone has ideas about the error above, that would be super helpful. I don't think this should block finishing the package review on this package, however, and the build issue can be solved separately after we get the initial package (47.beta) in. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
