https://bugzilla.redhat.com/show_bug.cgi?id=2317585 --- Comment #33 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- (In reply to Stephen John Smoogen from comment #32) > 3. > ``` > Is there a reason you are not using > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #pyproject_buildrequires and rather specifying deps manually? This is only a > SHOULD so manually specifying wont block the review. > > According to the docs you should be using it if you use %pyproject_wheel: > ``` > > I tried using it and found it was pulling in requirements which are at best > 'recommendations' versus 'requires'. This was causing problems with it even > building because some of them are not packaged in Fedora yet and I didn't > want to vendor them in. I am open to suggestions on how to fix that. I think we are going to need to package whatever %pyproject_buildrequires detects before it's smart to approve this. We really shouldn't be shipping software that will be broken depending on how users configure/use the package. If it's truly modular, we need to make sure to patch out/remove the functionality that is missing dependencies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c33 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
