https://bugzilla.redhat.com/show_bug.cgi?id=2317585 --- Comment #32 from Stephen John Smoogen <smooge@xxxxxxxxxx> --- To answer questions above: 1. ``` Is there a reason you are not using %autorelease? ``` The reason for not using %autorelease was to get it through the review process. I had problems in the past where having 'updates' to fix the last change would not work because the tool saw it as the same version as the last and new builds weren't getting kicked off for fedora-review and such. I will changed it back to %{autorelease} with the hope that works 2. ``` # temporary patch until upstream fixes make Patch1: 0001-ramalama-v0.0.20_fixf39.patch This patch should reference an upstream issue or pull request. ``` I was following: ``` Fedora-specific (or rejected upstream) patches It may be that some patches truly are Fedora-specific; in that case, say so: # This patch is temporary until we land the long term System.loadLibrary fix in OpenJDK Patch: jna-jni-path.patch ``` I am making a PR and will reference that in the next round. 3. ``` Is there a reason you are not using https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_buildrequires and rather specifying deps manually? This is only a SHOULD so manually specifying wont block the review. According to the docs you should be using it if you use %pyproject_wheel: ``` I tried using it and found it was pulling in requirements which are at best 'recommendations' versus 'requires'. This was causing problems with it even building because some of them are not packaged in Fedora yet and I didn't want to vendor them in. I am open to suggestions on how to fix that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c32 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
