https://bugzilla.redhat.com/show_bug.cgi?id=2319426 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for the feedback. > - Packaging guidelines state that there should be a separator between the > snapshot date and the revision ('.', 'git', or 'g' would be appropriate) [1] Added a '.' > - The license text isn't included when 'kookbook' is installed, but should be [2] > I believe there is a missing dependency on the -extras subpackage from the arched > base package Made this dependency of the base package. > - Inter-subpackage dependencies should be version-specific to avoid > partial upgrades: `= %{version}%{release}` Added this. Thanks. > - Consider using the %ctest macro, or at the very least %__ctest Used %ctest macro. > - Though krecipies.py is installed as a sort of example and isn't executable as-is, > consider requiring the Python interpreter needed to invoke it. Have left this for know. Will check with upstream on whether there is intent to fully develop it. spec: https://download.copr.fedorainfracloud.org/results/fed500/kookbook/fedora-rawhide-x86_64/08158373-kookbook/kookbook.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/kookbook/fedora-rawhide-x86_64/08158373-kookbook/kookbook-0.2.1%5E20240530.56b0c4d9-1.fc42.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2319426 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202319426%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
