https://bugzilla.redhat.com/show_bug.cgi?id=2317585 --- Comment #18 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0". 70 files have unknown license. This looks good. [!]: Changelog in prescribed format. Use either %autochangelog or manual entries for new packages. The only time I've seen both is when a package is already in distgit and is migrated to %autochangelog. This being a new package, just include %autochangelog [!]: Package should compile and build into binary rpms on all supported architectures. F39 is failing to build. Since this is a non-critical component, maybe guard the inclusion of the zsh completions. register-python-argcomplete --shell zsh ramalama > completions/zsh/vendor-completions/_ramalama usage: register-python-argcomplete [-h] [--no-defaults] [--complete-arguments ...] [-s {bash,tcsh,fish}] [-e EXTERNAL_ARGCOMPLETE_SCRIPT] executable [executable ...] register-python-argcomplete: error: argument -s/--shell: invalid choice: 'zsh' (choose from 'bash', 'tcsh', 'fish') [!]: %check is present and all tests pass. No check. If upstream doesn't have tests this is fine. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
