https://bugzilla.redhat.com/show_bug.cgi?id=2313902 Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alexjnewt@fastmai | |l.com) | --- Comment #4 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- Updated: Spec URL: https://mystro256.fedorapeople.org/rocdecode.spec SRPM URL: https://mystro256.fedorapeople.org/rocdecode-6.2.2-1.fc42.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/mystro256/playground/build/8157598/ > What files were BSD? Not sure why I put that there. Deleted. > The license file is not boilerplate MIT, can you include the non MIT part under the %license field ? Well I put a comment above "License:", is this what you had in mind? As for %license, I did include the license file in question. As per the guidelines, the license field isn't legally binding, hence the need for the license macro and license file from source. The clause also doesn't really affect the MIT licensing, it's more of a clarification/reminder that the user doesn't get the codecs for free when using this software. > could this be done with a sed line in %prep ? Done, also made a PR for the patch upstream, so it can hopefully be dropped in the near future. > Other rocm packages have --with debug and --with test options. So I just put the "with test" condition in there. The tests don't actually work due to some cmake logic bugginess, but I suspect it actually requires ffmpeg-freeworld from rpmfusion for some tests to work correctly anyway. I'll leave it disabled for now with a note. > If it is too much effort to get them in shape, drop including them. The samples appear to be used in the tests. I'm unsure how valuable they are, so I just dropped them for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313902 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313902%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
