https://bugzilla.redhat.com/show_bug.cgi?id=2313902 Tom.Rix@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(alexjnewt@fastmai | |l.com) Status|NEW |ASSIGNED --- Comment #3 from Tom.Rix@xxxxxxx --- No gcc is fine, the checker is not smart enough to figure out dependencies of hip's cc. The SPDX check is nagging about 'and' it prefers 'AND' What files were BSD? The license file is not boilerplate MIT, can you include the non MIT part under the %license field ? This part: NOTICE REGARDING STANDARDS AMD does not provide a license or sublicense to any Intellectual Property Rights relating to any standards, including but not limited to any audio and/or video codec technologies such as MPEG-2, MPEG-4; AVC/H.264; HEVC/H.265; AAC decode/FFMPEG; AAC encode/FFMPEG; VC-1; and MP3 (collectively, the “Media Technologies”). For clarity, you will pay any royalties due for such third party technologies, which may include the Media Technologies that are owed as a result of AMD providing the Software to you. For the patch to deal with llvm/bin/clang++, could this be done with a sed line in %prep ? Other rocm packages have --with debug and --with test options. Please add these and if they are not mockable, note why. ex/ downloads stuff.. I like the idea of having samples, but they need to work, these do not. If it is too much effort to get them in shape, drop including them. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2313902 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313902%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
