[Bug 2306380] Review Request: rust-delharc - Library for parsing and extracting files from LHA/LZH archives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2306380



--- Comment #6 from Orion Poplawski <orion@xxxxxxxx> ---
Spec URL: https://orion.fedorapeople.org/rust-delharc.spec
SRPM URL: https://orion.fedorapeople.org/rust-delharc-0.6.1-1.fc42.src.rpm

(In reply to Fabio Valentini from comment #5)
> Thanks, looks pretty good to me, just a few minor things:
> 
> > rust-delharc-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/delharc-0.6.1/CHANGELOG.md
> > rust-delharc-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/delharc-0.6.1/README.md
> 
> Please fix these up in %prep, either with sed or with dos2unix.

Done.

> > rust-delharc.src: W: strange-permission delharc-0.6.1.crate 660
> > rust-delharc.src: W: strange-permission delharc-fix-metadata.diff 660
> > rust-delharc.src: W: strange-permission rust-delharc-0.6.1-github.tar.gz 660
> > rust-delharc.src: W: strange-permission rust-delharc.spec 660
> 
> This looks like an artifact from the environment where you built the SRPM -
> did you use a folder under /tmp ?

I've been using a umask of 0007.  I've reset to a more normal 0022.


Is there a standard way to include the rust2rpm.toml file in the spec/srpm?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2306380

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202306380%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux