https://bugzilla.redhat.com/show_bug.cgi?id=2306380 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks, looks pretty good to me, just a few minor things: > rust-delharc-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/delharc-0.6.1/CHANGELOG.md > rust-delharc-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/delharc-0.6.1/README.md Please fix these up in %prep, either with sed or with dos2unix. > rust-delharc.src: W: strange-permission delharc-0.6.1.crate 660 > rust-delharc.src: W: strange-permission delharc-fix-metadata.diff 660 > rust-delharc.src: W: strange-permission rust-delharc-0.6.1-github.tar.gz 660 > rust-delharc.src: W: strange-permission rust-delharc.spec 660 This looks like an artifact from the environment where you built the SRPM - did you use a folder under /tmp ? > GNU General Public License, Version 2 > ------------------------------------- > rust-delharc-0.6.1-build/delharc-0.6.1/tests/decode/lh0.bin It looks like this ".bin" file just ... contains a copy of the GPL-2.0 license text verbatim, with some non-ASCII junk added in front? If this is just test data, fine. It just looks weird in the licensecheck output. I've checked that none of the binary test files end up in the built package, so that should be OK too. > tar xvf %SOURCE2 --strip-components=1 %{name}-%{version}/tests/\* This looks very strange, and I'm surprised it works. But if it does ... then ok :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2306380 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202306380%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
