[Bug 2317585] Review Request: ramalama - RamaLama is a command line tool for working with AI LLM models.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2317585



--- Comment #8 from Stephen John Smoogen <smooge@xxxxxxxxxx> ---
To answer one item:
```
[!]: Package meets the Packaging Guidelines::Python

Please re-read
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

I'm noticing things like the use of %{python3_pkgversion} when it should be
%{python3_version} or %{python3_version_nodots}.

I also wonder why you didn't use %pyproject_buildrequires techniques. We should
use those if it's possible.

```

I tried using %{python3_version} in replacement of %{python3_pkgversion} and it
did not work in `mock` but it would work in `rpmbuild`. I then downloaded all
the Fedora spec files to see what was being used in rawhide, and found that
packages like python3-wheel and others still used the _pkgversion syntax.

I was also having problems trying to use %pyproject_buildrequires and they were
causing different errors depending if I was using epel-9 or fedora-rawhide. I
will need to work with the upstream to get the requirements and other tooling
to work correctly.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2317585

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux