https://bugzilla.redhat.com/show_bug.cgi?id=2317585 --- Comment #7 from Stephen John Smoogen <smooge@xxxxxxxxxx> --- (In reply to Jonathan Steffan from comment #3) > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "MIT License", "*No copyright* Apache > License 2.0". 70 files have unknown license. Detailed output of > licensecheck in /home/jon/Reviews/python-ramalama/licensecheck.txt > > License is MIT > > > [!]: Package meets the Packaging Guidelines::Python > > Please re-read > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > I'm noticing things like the use of %{python3_pkgversion} when it should be > %{python3_version} or %{python3_version_nodots}. > > I also wonder why you didn't use %pyproject_buildrequires techniques. We > should use those if it's possible. > > I think the idea was how to deal with EPEL versions but it could be following older guidelines. I will update the upstream spec and fix here. > [!]: Latest version is packaged. > > New version available. > > > [!]: SourceX tarball generation or download is documented. > Note: Package contains tarball without URL, check comments > > Update the source to be a link to an upstream release tar. > This was built via packit the first time and I missed that it didn't do this. I will see if this can be 'fixed' and if not will fix the one in review. > > [!]: %check is present and all tests pass. > > No tests are being ran. We should add these. > I will feed this upstream.. checks may not be possible without internet access but this can be worked on. > > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define > _python_dist_allow_version_zero 1 Will review the python packaging guidelines and properly fix. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
