Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: upstart - an event-driven init daemon https://bugzilla.redhat.com/show_bug.cgi?id=429028 notting@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |notting@xxxxxxxxxx ------- Additional Comments From notting@xxxxxxxxxx 2008-01-31 15:08 EST ------- MUST: - Package meets naming guidelines - OK - Spec file matches base package name. - OK - Spec has consistant macro usage. - *** - Meets Packaging Guidelines. - OK - License - GPLv2+ - OK - License field in spec matches - OK - License file included in package - *** - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: 794208083d405ece123ad59a02f3e233 - OK - Package needs ExcludeArch - N/A - BuildRequires correct - OK - Spec handles locales/find_lang - OK - Package has %defattr and permissions on files is good. - OK - Package has a correct %clean section. - OK - Package has correct buildroot - OK - Package is code or permissible content. - OK - Doc subpackage needed/used. - N/A - Packages %doc files don't affect runtime. - OK, once they're added - Headers/static libs in -devel subpackage. - N/A, nuked - Spec has needed ldconfig in post and postun - OK - .pc files in -devel subpackage/requires pkgconfig - N/A - .la files are removed. - OK - Package compiles and builds on at least one arch. - once issue #1 addressed, yes (tested x86_64) - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. - OK - No rpmlint output. upstart.x86_64: W: conffile-without-noreplace-flag /etc/event.d/logd This may be OK, if this isn't meant to be user modified. - final provides and requires are sane: *** SHOULD Items: - Should build in mock. - OK (tested x86_64) - Should build on all supported archs - didn't test ppc - Should function as described. - *** - Should have sane scriptlets. - N/A - Should have dist tag - OK - Should package latest version - OK Issues: 1) %configure --enable-compat=sysv --sbindir=/sbin --libdir=/lib Needs to be --libdir=/%{_lib}, otherwise build will fail on x86_64, ppc64. 2) No docs, including licenses Probably should include ChangeLog, AUTHORS, COPYING, NEWS, README, TODO, HACKING 3) Should this package require event-compat-sysv? Should it obsolete/provide sysvinit? 4) Re: functionality. I think that will go in a separate bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review