Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: MyBashBurn - burn data and songs. Alias: MyBashBurn https://bugzilla.redhat.com/show_bug.cgi?id=217197 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-31 15:00 EST ------- OK, the license is fixed, but the tarball still does not match the upstream tarball. If you have a Source0: url of http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz then I simply must be able to download that tarball and get exactly, byte for byte, what you are including in the srpm. It is not acceptable for you to modify that tarball in any way unless it contains content which we cannot legally distribute. If you are packaging something out of upstream SVN, we have rules about how you document that. You certainly cannot use the same version name because what you want to distribute is not the same as what upstream ships with that version. So please see http://fedoraproject.org/wiki/Packaging/NamingGuidelines. And if you are going to package an SVN checkout then we also have rules about how you document that so that I can make the same SVN checkout as you made: http://fedoraproject.org/wiki/Packaging/SourceURL. But honestly, do you have some compelling reason not to just ship what upstream ships? Just use their tarball in place of whatever you are trying to package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review