https://bugzilla.redhat.com/show_bug.cgi?id=2255751 --- Comment #29 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Issues: ======= - Header files in -devel subpackage, if present. Note: perfetto-sdk : /usr/share/perfetto/sdk/perfetto.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages These are fine for now, relying on providing a -sdk instead. [!]: Development files must be in a -devel package Using a -sdk instead. [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perfetto-libs , perfetto-sdk This seems correct and intentional to be able to install the libs or sdk independently without anything else. Is the perfetto-libs subpackage useful even without the main package files? It seems like it should be. [!]: %check is present and all tests pass. Upstream tests are not accessible. [!]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate Currently not using tmpfiles.d. Should we be? [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Should the SDK be noarch? Seems so. I also recommend we use the https://github.com/google/perfetto repo as the source because it's easier to see what is going on, etc. The Google source control system is ... very Googly. Both are fine so this is just a preference. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255751 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255751%23c29 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
