https://bugzilla.redhat.com/show_bug.cgi?id=2313339 --- Comment #19 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Thomas Fitzsimmons from comment #18) > I think we should resolve the policy decision first before adding logic like: > > cat %{SOURCE2} | sed "s/^enabled=0/enabled=%{enabled_by_default}/" > > %{reponame} > > Resolve the policy, then hard-code the correct value. If the policy changes > later, update the spec file to hard-code the new correct value. (I am I added the logic in here, because the value may differ in individual versions. eg in f39,40and 41 it will be disabled. For f42 and f43 we get fesco exception and and it will be enbabled. In f44 we lost it again.... It seems to be more trackable from specile, as it is much more visible. > pretty sure you want sed -i there instead, since I think what you have will > blank the file.) Nope. I may be wrong, but modyfing the SOURCEx directly is considered bad practice (maybe it is even read only). In all specfiles I always met, a cpy was done when SOURCEx was about to chnage. Anyway it si not blank file :) > > And I did not mean for you to copy "Fedora package repository files for yum > and dnf along with gpg public keys." verbatim for the summary. Then please suggests anything else. I did my best with original one. Yours seemed to be similarly correct, so it have one more vote. > > I will now put this review on the back burner until some of the policy > decisions we discussed are made; they will affect the content of the spec > file. If you need it to be approved sooner, feel free to assign it to > someone else. ok. TYVM! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313339%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
