https://bugzilla.redhat.com/show_bug.cgi?id=2313339 --- Comment #18 from Thomas Fitzsimmons <fitzsim@xxxxxxxxxx> --- I think we should resolve the policy decision first before adding logic like: cat %{SOURCE2} | sed "s/^enabled=0/enabled=%{enabled_by_default}/" > %{reponame} Resolve the policy, then hard-code the correct value. If the policy changes later, update the spec file to hard-code the new correct value. (I am pretty sure you want sed -i there instead, since I think what you have will blank the file.) And I did not mean for you to copy "Fedora package repository files for yum and dnf along with gpg public keys." verbatim for the summary. I will now put this review on the back burner until some of the policy decisions we discussed are made; they will affect the content of the spec file. If you need it to be approved sooner, feel free to assign it to someone else. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313339%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
