https://bugzilla.redhat.com/show_bug.cgi?id=2283064 --- Comment #8 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #7) > > The following ones should be justified (tests fail?) > > BuildRequires: python3dist(responses) > > BuildRequires: python3dist(unidiff) > > Yes. > tests/conftest.py:6: in <module> > import responses > E ModuleNotFoundError: No module named 'responses' > and > E NotImplementedError: SecretsCollection.scan_diff requires > `unidiff` to work. Try pip installing that package, and try again. Ok, then please add a comment to the SPEC file so that they'll be justified. > > ===== SHOULD items ===== > [...] > > [!]: %check is present and all tests pass. > > https://github.com/Yelp/detect-secrets/issues/875 justifies exclusion of > > only 9 failing test. You exclude 33 of them. What's the justification for > > the remaining tests? > > Some require an unpackaged dependency (gibberish-detector). > Others require git and upstream git repo clone as part of the tarball, but > GitHub-generated tarball doesn't include git metadata. The standard way > is to use a tarball, so I disabled the git tests and did not include git-core > as a build dependency. What do you suggest instead? I just tried to run test_modifies_baseline (it was not listed on github) and it fails due to git as well. It seems that you did the right thing. Please update your SPEC file, and I'll approve it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283064 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283064%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
