https://bugzilla.redhat.com/show_bug.cgi?id=2283064 --- Comment #7 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to wojnilowicz from comment #6) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > > Shouldn't you use "BuildRequires: python3dist(pytest)" instead of > "BuildRequires: python3-pytest" as mentioned at > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_test_dependencies_2 to make this issue go away? Switched to python3dist(foo) scheme. > Could you fix those two warnings with the help of > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages ? > python3-detect-secrets.noarch: W: no-manual-page-for-binary detect-secrets > python3-detect-secrets.noarch: W: no-manual-page-for-binary > detect-secrets-hook > > ===== MUST items ===== [...] > [!]: Requires correct, justified where necessary. > Builds without "BuildRequires: python3-pytest-xdist" and not justified. Removed. > The following ones are picked up by "%pyproject_buildrequires -x word_list" > BuildRequires: python3dist(pyahocorasick) > BuildRequires: python3dist(pyyaml) > BuildRequires: python3dist(requests) > Build fails without them for you? If not, they should be removed. Removed. > The following ones should be justified (tests fail?) > BuildRequires: python3dist(responses) > BuildRequires: python3dist(unidiff) Yes. tests/conftest.py:6: in <module> import responses E ModuleNotFoundError: No module named 'responses' and E NotImplementedError: SecretsCollection.scan_diff requires `unidiff` to work. Try pip installing that package, and try again. > ===== SHOULD items ===== [...] > [!]: %check is present and all tests pass. > https://github.com/Yelp/detect-secrets/issues/875 justifies exclusion of > only 9 failing test. You exclude 33 of them. What's the justification for > the remaining tests? Some require an unpackaged dependency (gibberish-detector). Others require git and upstream git repo clone as part of the tarball, but GitHub-generated tarball doesn't include git metadata. The standard way is to use a tarball, so I disabled the git tests and did not include git-core as a build dependency. What do you suggest instead? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283064 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283064%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
