https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |ASSIGNED --- Comment #37 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > Obsoletes: python3-pyliblo < 0.10.0-30 This needs to be moved in the python3-pyliblo3 subpackage, otherwise it does nothing (assuming you follow the other steps bellow). > %package -n python3-%{modname} > Summary: %{summary} The %{summary} expands to the previous Summary in the specfile, hence "Documentation for python-pyliblo3". Either move the doc subpackage after the python3-pyliblo3 subpackage or avoid using %{summary} here. > Recommends: python3-pyliblo3 This is self-referencing Recommends. What is the idea behind it? > %files -n python-pyliblo3 -f %{pyproject_files} This needs to be python3-pyliblo3, not python-pyliblo3. Currently, the python3-pyliblo3 package is not generated because it has no %files section. Instead, the python-pyliblo3 package is generated which we don't want. ---- > There is a constant debate if macros like `modname` are necessary or not, just be consistent in the usage. Exactly, the specfile has 3 uses of %{modname} and 16 uses of pyliblo3 (excluding the %changelog entries). Pick one, and stick with it. My opinion is that using %{modname} only makes the specfile harder to read and maintain. --- Once again I'd like to point out the example Python specfile in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file which should give you the general idea about the package structure. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c37 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
