https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged | --- Comment #36 from Cristian Le <fedora@xxxxxxxxx> --- - Please remove the `-t` in the `%pyproject_buildrequires -t`. That is for using `tox` which this version doesn't use it anymore - Any reason for reverting from `autospec` macros? Other than that, it looks ok. There is a constant debate if macros like `modname` are necessary or not, just be consistent in the usage. I am on the camp of removing them until there are tools like `rust2rpm` that would make use of it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c36 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
