https://bugzilla.redhat.com/show_bug.cgi?id=2296542 --- Comment #10 from Cristian Le <fedora@xxxxxxxxx> --- > > Source2: https://github.com/LecrisUT/tonic/raw/packaging/fedora/LICENSE-APACHE > > This link is no longer valid. If you need to include an external Apache-2.0 > license text, please use the official one, not a custom link: > > https://www.apache.org/licenses/LICENSE-2.0.txt The link should still be available, and I am mostly unsure if upstream would want to change the template copyright part or not. sqlx do that change. But yeah, I'll switch it to a static bundled file. > > BuildRequires: protobuf-devel > > Is this really needed here? I thought prost should already pull in protobuf > - or do you need protoc? That one is in "protobuf-compiler". > If it is /usr/bin/protoc that you need, then I wonder why 1) it's not pulled > in correctly by prost, and 2) you could just depend on "BR: /usr/bin/protoc" > directly, without guessing the package name. I need to parts from here the `protoc` and the std libraries themselves. I have previously tried to build `atuin` locally with `protobuf-compiler` and it failed because it couldn't find the appropriate libraries. I just double-checked for this package as well by changing it to `BR: /usr/bin/protoc` and I get: ``` Running `/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2/target/rpm/build/tonic-types-b1705e977b60cfc9/build-script-build` error: failed to run custom build command for `tonic-types v0.12.2 (/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2)` Caused by: process didn't exit successfully: `/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2/target/rpm/build/tonic-types-b1705e977b60cfc9/build-script-build` (exit status: 101) --- stdout cargo::rerun-if-changed=/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2/proto/status.proto cargo::rerun-if-changed=/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2/proto/error_details.proto cargo::rerun-if-changed=/builddir/build/BUILD/rust-tonic-types-0.12.2-build/tonic-types-0.12.2/proto --- stderr thread 'main' panicked at build.rs:51:10: called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "protoc failed: google/protobuf/any.proto: File not found.\nstatus.proto:19:1: Import \"google/protobuf/any.proto\" was not found or had errors.\nstatus.proto:46:12: \"google.protobuf.Any\" is not defined.\n" } note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: Bad exit status from /var/tmp/rpm-tmp.Gc0TDy (%build) Bad exit status from /var/tmp/rpm-tmp.Gc0TDy (%build) ``` ```console $ dnf repoquery --whatprovides */google/protobuf/any.proto erlang-gpb-0:4.21.1-2.fc41.noarch golang-github-gogo-protobuf-devel-0:1.3.2-16.fc41.noarch mingw32-protobuf-0:3.19.6-6.fc41.noarch mingw64-protobuf-0:3.19.6-6.fc41.noarch protobuf-devel-0:3.19.6-10.fc41.i686 protobuf-devel-0:3.19.6-10.fc41.x86_64 python3-grpcio-tools-0:1.48.4-41.fc41.x86_64 rust-protobuf-codegen-pure-devel-0:2.28.0-4.fc41.noarch ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2296542 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296542%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
