https://bugzilla.redhat.com/show_bug.cgi?id=2296542 --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Source2: https://github.com/LecrisUT/tonic/raw/packaging/fedora/LICENSE-APACHE This link is no longer valid. If you need to include an external Apache-2.0 license text, please use the official one, not a custom link: https://www.apache.org/licenses/LICENSE-2.0.txt > BuildRequires: protobuf-devel Is this really needed here? I thought prost should already pull in protobuf - or do you need protoc? That one is in "protobuf-compiler". If it is /usr/bin/protoc that you need, then I wonder why 1) it's not pulled in correctly by prost, and 2) you could just depend on "BR: /usr/bin/protoc" directly, without guessing the package name. The patch to add build.rs looks good to me, and the package in general looks fine, with these two exceptions. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2296542 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296542%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
