[Bug 2307694] Review Request: aribb24 - A library for ARIB STD-B24

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2307694



--- Comment #6 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Yaakov Selkowitz from comment #5)
> First off, this has not been updated upstream in years; it is really still
> useful?

It has been the main support in ffmpeg (and still is) for anything ARIB
STD-B24. I think it will be eventually replaced completely by libaribcaption,
but I can't tell.

> Adding the git snapshot information to Release is deprecated; current
> guidelines state these should be in Version instead:
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> #_snapshots
> 
> Which would look something like:
> 
> Version:        1.0.3%{!?tag:^%{date}git%{shortcommit0}}
> Release:        2%{?dist}

Doh, I was not aware it changed. I guess I will update all packages that I
maintain with snapshots in the name.

> BTW, why is release 2 and not 1?

Leftover I guess, I will reuse 1.

> Drop the Requires: pkg-config from -devel.
> 
> In %files devel, change %{_includedir}/%{name}/*.h to just
> %{_includedir}/%{name}/ so that the directory is also owned.

Done.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2307694

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307694%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux