https://bugzilla.redhat.com/show_bug.cgi?id=2307694 Yaakov Selkowitz <yselkowi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yselkowi@xxxxxxxxxx --- Comment #5 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- First off, this has not been updated upstream in years; it is really still useful? Adding the git snapshot information to Release is deprecated; current guidelines state these should be in Version instead: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots Which would look something like: Version: 1.0.3%{!?tag:^%{date}git%{shortcommit0}} Release: 2%{?dist} BTW, why is release 2 and not 1? Drop the Requires: pkg-config from -devel. In %files devel, change %{_includedir}/%{name}/*.h to just %{_includedir}/%{name}/ so that the directory is also owned. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2307694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307694%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
