https://bugzilla.redhat.com/show_bug.cgi?id=2270199 --- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Simone Caronni from comment #5) > Looks good to me, package approved. Thanks! > Just a couple of questions: > > - Shall we add libfreenect to Fedora and then remove the %with_freenect > conditional? It's in Fedora already. I'll verify the support status in gpac. > - Do we need the static archive subpackage? Yes, it's useful not to link the whole gpac-libs (and bring its dependencies) to x264. Also, it helps break a dependency loop. > - Regarding the bug mentioned: > > #config.h like but not only > #Usual multilib bug https://bugzilla.rpmfusion.org/show_bug.cgi?id=270 > sed -i -e '/GPAC_CONFIGURATION/d' > %{buildroot}%{_includedir}/gpac/configuration.h > > I haven't checked in detail as the bug thread is very long and old (livna > times), are you sure it still applies? I think I checked it when I was preparing the Fedora package, but I'll re-check. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270199 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270199%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
