https://bugzilla.redhat.com/show_bug.cgi?id=2270199 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- Looks good to me, package approved. Just a couple of questions: - Shall we add libfreenect to Fedora and then remove the %with_freenect conditional? - Do we need the static archive subpackage? - Regarding the bug mentioned: #config.h like but not only #Usual multilib bug https://bugzilla.rpmfusion.org/show_bug.cgi?id=270 sed -i -e '/GPAC_CONFIGURATION/d' %{buildroot}%{_includedir}/gpac/configuration.h I haven't checked in detail as the bug thread is very long and old (livna times), are you sure it still applies? Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270199 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270199%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
