https://bugzilla.redhat.com/show_bug.cgi?id=2308448 --- Comment #2 from mulhern <amulhern@xxxxxxxxxx> --- > > 4. "%cargo_test -- --no-run" > > This is both a) not the way to disable tests, (that would be flipping the > %check bcond), and b) *if* you need to disable tests, it needs to be > documented *why*. > > So you need to remove the "--no-run" arg here and either 1) flip the check > bcond and document why you cannot run *any* tests, or 2) run tests and just > skip specific ones that can't be run. The --no-run option does something substantially useful; it checks that the tests can be built into an executable without actually trying to run them. Ensuring that the tests can be built is worth doing during the package build process, I think. For this package the tests that are available are integration tests. The requirements to run the tests are far too heavy for the package build environment. So, I think it should be kept as is, but adding the following comment above the %cargo_test line, which I propose to Ming Lei: # Just build the tests. The tests are integration tests that require extensive # environment setup to be run, as documented in the ci directory in the upstream # GitHub repository. Something like that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308448%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
