https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I'll take a look. Quick first impressions: 1. FIXME > # FIXME: paste output of %%cargo_license_summary here > License: # FIXME This needs to be addressed. 2. BuildRequires: clang Likely you only need clang-libs, if this is due to bindgen. 3. License: GPL-2.0 "GPL-2.0" is a deprecated identifier in SPDX 3.0 and not valid in Fedora. You need to fix this to be either "GPL-2.0-only" or "GPL-2.0-or-later", ideally upstream. 4. "%cargo_test -- --no-run" This is both a) not the way to disable tests, (that would be flipping the %check bcond), and b) *if* you need to disable tests, it needs to be documented *why*. So you need to remove the "--no-run" arg here and either 1) flip the check bcond and document why you cannot run *any* tests, or 2) run tests and just skip specific ones that can't be run. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308448%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
