https://bugzilla.redhat.com/show_bug.cgi?id=2308280 --- Comment #6 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Neal Gompa from comment #5) > Review notes: > > * Package was generated by rust2rpm, simplifying the review > * Package licensing is correct and license files are correctly handled > * Package builds and installs > * Package has no serious issues from fedora-review or rpmlint > > Some notes to fix on import: > > > %global crate_version 0.1.0-rc.0 > > You can use %{version_no_tilde} instead to get this from the Version: tag. > I think rust2rpm used to do this and now does the crate_version / version separately > > Requires: pkgconf-pkg-config > > This is unneeded as we generate a "Requires: /usr/bin/pkg-config" > Good to know, thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2308280 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308280%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
