https://bugzilla.redhat.com/show_bug.cgi?id=2308280 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx CC| |ngompa13@xxxxxxxxx Flags| |fedora-review+ --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package was generated by rust2rpm, simplifying the review * Package licensing is correct and license files are correctly handled * Package builds and installs * Package has no serious issues from fedora-review or rpmlint Some notes to fix on import: > %global crate_version 0.1.0-rc.0 You can use %{version_no_tilde} instead to get this from the Version: tag. > Requires: pkgconf-pkg-config This is unneeded as we generate a "Requires: /usr/bin/pkg-config" Otherwise, this is good to go, so... PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2308280 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308280%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
