https://bugzilla.redhat.com/show_bug.cgi?id=2305342 --- Comment #8 from Davide Cavalca <davide@xxxxxxxxxxxx> --- > These are not used and part of the packaging, instead we should strip it at prep and just drop these lines. So right now these are gated by the integration bcond, as afaik they are needed for the integration tests, but not for the actual build. I can drop them, but I suspect the integration tests just won't work (we disable them by default, so not an issue for the package itself in practice). I also just realized now instead of doing conditional sources I should do conditional unpacking to ensure the src.rpm is reproducible. Will fix that. > This should be updated to recent values because the hash doesn't seem to exist in the FEX GitHub repo, so I got confused when I looked over it. Oh yeah that was just copypasta from another package :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305342 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305342%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
