https://bugzilla.redhat.com/show_bug.cgi?id=2305342 --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: [x]: Package follows Fedora packaging guidelines [!]: Bundled dependencies are documented > { name="fex-gcc-target-tests-bins", ref="442678a", owner="FEX-Emu", license="GPL-2.0-or-later", bcond="integration" }, > { name="fex-gvisor-tests-bins", ref="71349ae", owner="FEX-Emu", license="Apache-2.0", bcond="integration" }, > { name="fex-posixtest-bins", ref="9ae2963", owner="FEX-Emu", package="posixtest", version="1.5.2", license="GPL-2.0-or-later", bcond="integration" }, These are not used and part of the packaging, instead we should strip it at prep and just drop these lines. [x]: Latest sources are packaged > #global date 20240101 > #global commit 4a0e9289bf443fec9fc56af25f90e2a100ba7a41 This should be updated to recent values because the hash doesn't seem to exist in the FEX GitHub repo, so I got confused when I looked over it. [x]: Package builds and installs Once the following things are fixed, we should be good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305342 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305342%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
