https://bugzilla.redhat.com/show_bug.cgi?id=2304835 Attila Kovacs <attipaci@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #1 from Attila Kovacs <attipaci@xxxxxxxxx> --- To the reviewer: I have a few questions regarding the packaging... 1. The upstream source is published under the Apache 2.0 license, albeit with an exception. The exception relates to the redistribution of the _unmodified_ source only, as released by NAIF. I have obtained explicit permission from the NAIF manager to package CSPICE for Fedora. The packaging is necessarily a modification of the original distribution (both for the SRPM and the RPMS). As such the Fedora packages should be exempt from the upstream licensing exception entirely, and can be further distributed with the unmodified Apache 2.0 license. Nevertheless, the LICENSE file included in the distribution mentions the exception relating to the redistribution of the upstream code, just to be sure. I expect this should be OK. I just wanted to clarify it. 2. The upstream release is versioned as `N0067`. However, all prior releases of the library were API and ABI back-compatible to my knowledge. As such, I added the major version of 1 for the Fedora package, and set the minor version to 67. Is that OK, or should the Fedora package contain the original `N0067` in the version, e.g. a `1.N0067`? 3. The upstream did not include a license file, so I have created one that was approved by the NAIF manager in the prep stage. Would there be a better way to pull this license file from e.g. a separate git repo? 4. The prep stage modifies the unpacked upstream tarball as necessary to remove the prebuilt binaries, to build shared libraries (instead of static ones), and to skip the unwanted steps. Maybe this could live in a shell script externally also, e.g. in a separate git repo (e.g. same one as for the license)? Thanks in advance for your review. -- A. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2304835 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304835%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
