https://bugzilla.redhat.com/show_bug.cgi?id=2303993 --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ [Not applicable because this is a pure OCaml package.] ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Checked upstream, the license is ISC (https://spdx.org/licenses/ISC.html) [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License", "*No copyright* ISC License [generated file]". 34 files have unknown license. Detailed output of licensecheck in /var/tmp/review/2303993-ocaml-opam-0install- cudf/licensecheck.txt I checked upstream and it's OK. They're just not very good at marking files. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc, /usr/share, /usr/share/licenses, /usr, /usr/lib64/ocaml, /usr/lib, /usr/lib64 I think this is a bug in fedora-review. These directories do not appear in the RPM itself, and the directories that do appear are correct. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/share/licenses, /usr, /usr/lib64/ocaml, /usr/lib, /usr/lib64, /usr/share As above. [x]: %build honors applicable compiler flags or justifies otherwise. Uses dune to build. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. Uses autochangelog. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!?]: If the package is a rename of another package, proper Obsoletes and Provides are present. Jerry, do we want Obsoletes & Provides for this one? [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8267 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Did not test, but we will do builds with this later. [x]: Latest version is packaged. Latest upstream is 0.4.3 released Apr 28, 2022, and this version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-opam-0install-cudf-0.4.3-2.fc41.x86_64.rpm ocaml-opam-0install-cudf-devel-0.4.3-2.fc41.x86_64.rpm ocaml-opam-0install-cudf-0.4.3-2.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2c52yk3c')] checks: 32, packages: 3 ocaml-opam-0install-cudf-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/opam-0install-cudf/opam_0install_cudf.a ocaml-opam-0install-cudf.src: E: spelling-error ('duniverse', '%description -l en_US duniverse -> universe, d universe, diverse') ocaml-opam-0install-cudf.x86_64: E: spelling-error ('duniverse', '%description -l en_US duniverse -> universe, d universe, diverse') ocaml-opam-0install-cudf-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 3 errors, 1 warnings, 11 filtered, 3 badness; has taken 0.2 s Rpmlint (debuginfo) ------------------- Checking: ocaml-opam-0install-cudf-debuginfo-0.4.3-2.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3_37_ccw')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ocaml-opam-0install-cudf-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/opam-0install-cudf/opam_0install_cudf.a ocaml-opam-0install-cudf.x86_64: E: spelling-error ('duniverse', '%description -l en_US duniverse -> universe, d universe, diverse') ocaml-opam-0install-cudf-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 1 warnings, 13 filtered, 2 badness; has taken 0.3 s Source checksums ---------------- https://github.com/ocaml-opam/opam-0install-cudf/archive/v0.4.3/opam-0install-cudf-0.4.3.tar.gz : CHECKSUM(SHA256) this package : 56834eea2767a07cec011f69d57b6b9f153fdfc76dc5fde6e4b29a0b57bfedb8 CHECKSUM(SHA256) upstream package : 56834eea2767a07cec011f69d57b6b9f153fdfc76dc5fde6e4b29a0b57bfedb8 Requires -------- ocaml-opam-0install-cudf (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Cudf) ocaml(Cudf_types) ocaml(Opam_0install_cudf__) ocaml(Opam_0install_cudf__Model) ocaml(Opam_0install_cudf__S) ocaml(Option) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Fun) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__Map) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Uchar) ocaml(Zeroinstall_solver) ocaml(Zeroinstall_solver__) ocaml(Zeroinstall_solver__S) rtld(GNU_HASH) ocaml-opam-0install-cudf-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Cudf) ocaml(Cudf_types) ocaml(Opam_0install_cudf__) ocaml(Opam_0install_cudf__Model) ocaml(Opam_0install_cudf__S) ocaml(Option) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Fun) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__Map) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Uchar) ocaml(Zeroinstall_solver) ocaml(Zeroinstall_solver__) ocaml(Zeroinstall_solver__S) ocaml-opam-0install-cudf(x86-64) ocamlx(CamlinternalFormat) ocamlx(Cudf) ocamlx(Opam_0install_cudf__Model) ocamlx(Option) ocamlx(Stdlib) ocamlx(Stdlib__Format) ocamlx(Stdlib__List) ocamlx(Stdlib__Printf) ocamlx(Stdlib__String) ocamlx(Zeroinstall_solver) ocamlx(Zeroinstall_solver__Diagnostics) ocamlx(Zeroinstall_solver__Solver_core) Provides -------- ocaml-opam-0install-cudf: ocaml(Opam_0install_cudf) ocaml(Opam_0install_cudf__) ocaml(Opam_0install_cudf__Model) ocaml(Opam_0install_cudf__S) ocaml-opam-0install-cudf ocaml-opam-0install-cudf(x86-64) ocaml-opam-0install-cudf-devel: ocaml(Opam_0install_cudf) ocaml(Opam_0install_cudf__) ocaml(Opam_0install_cudf__Model) ocaml(Opam_0install_cudf__S) ocaml-opam-0install-cudf-devel ocaml-opam-0install-cudf-devel(x86-64) ocamlx(Opam_0install_cudf) ocamlx(Opam_0install_cudf__) ocamlx(Opam_0install_cudf__Model) ocamlx(Opam_0install_cudf__S) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2303993 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ocaml, C/C++, Shell-api Disabled plugins: fonts, Haskell, PHP, SugarActivity, R, Java, Perl, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2303993 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303993%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
