https://bugzilla.redhat.com/show_bug.cgi?id=2303167 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/carbon-c-relay See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names This is fine as this review is an un-retire review. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "Apache License 2.0 [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "Public domain". 154 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/carbon-c- relay/licensecheck.txt [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Only Apache-2.0 is addressed. I think we need to add the non-generated licenses and license files. [!]: %check is present and all tests pass. Check is disabled and the referenced issue has been resolved. Please enable tests again and open a new issue if there are still actually issues. carbon-c-relay.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/carbon-c-relay SSL_CTX_set_cipher_list This indicates the system crypto policy is not being used. This should be resolved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2303167 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303167%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
