https://bugzilla.redhat.com/show_bug.cgi?id=2295121 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Few small proposals. - You may use %pyproject_check_import uncionditionally. Guard with %if %{with tests}..%endif only %pytest. - No license was detected. See rpm -qpL ./python3-garth-0.4.46-1.fc41.noarch.rpm output. Try invoking %pyproject_save_files with -l switch. We need to add licensing info this way or another - this is a MUST. Apart from them I don't see any other issues so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text See my notes above. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (MIT). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag. [-]: No large documentation files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. I guess eggs are obsolete anyway. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not check if the package functions as described. [x]: Latest version is packaged (0.4.46). [x]: Package does not include license text files separate from upstream. [-]: Sources are not verified with gpgverify (upstream does not publish signatures). [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. Noarch package anyway. [x]: %check is present and all tests pass. See my notes above. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-garth-0.4.46-1.fc41.noarch.rpm python-garth-0.4.46-1.fc41.src.rpm ========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0yjxv9f5')] checks: 32, packages: 2 python-garth.src: E: spelling-error ('Garmin', 'Summary(en_US) Garmin -> Margin, Gamin, Gar min') python-garth.src: E: spelling-error ('auth', 'Summary(en_US) auth -> auto, Ruth, author') python-garth.src: E: spelling-error ('Garmin', '%description -l en_US Garmin -> Margin, Gamin, Gar min') python-garth.src: E: spelling-error ('auth', '%description -l en_US auth -> auto, Ruth, author') python3-garth.noarch: E: spelling-error ('Garmin', 'Summary(en_US) Garmin -> Margin, Gamin, Gar min') python3-garth.noarch: E: spelling-error ('auth', 'Summary(en_US) auth -> auto, Ruth, author') python3-garth.noarch: E: spelling-error ('Garmin', '%description -l en_US Garmin -> Margin, Gamin, Gar min') python3-garth.noarch: E: spelling-error ('auth', '%description -l en_US auth -> auto, Ruth, author') ==================================================================================================== 2 packages and 0 specfiles checked; 8 errors, 0 warnings, 10 filtered, 8 badness; has taken 1.3 s ===================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-garth.noarch: E: spelling-error ('Garmin', 'Summary(en_US) Garmin -> Margin, Gamin, Gar min') python3-garth.noarch: E: spelling-error ('auth', 'Summary(en_US) auth -> auto, Ruth, author') python3-garth.noarch: E: spelling-error ('Garmin', '%description -l en_US Garmin -> Margin, Gamin, Gar min') python3-garth.noarch: E: spelling-error ('auth', '%description -l en_US auth -> auto, Ruth, author') 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.4 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/g/garth/garth-0.4.46.tar.gz : CHECKSUM(SHA256) this package : 5ae19e67612083285b10321b8e0e1f7c815a8f60f21e2f13be8c21a22e64d8eb CHECKSUM(SHA256) upstream package : 5ae19e67612083285b10321b8e0e1f7c815a8f60f21e2f13be8c21a22e64d8eb Requires -------- python3-garth (rpmlib, GLIBC filtered): (python3.13dist(pydantic) < 3~~ with python3.13dist(pydantic) >= 1.10.12) (python3.13dist(requests) < 3~~ with python3.13dist(requests) >= 2) (python3.13dist(requests-oauthlib) < 2~~ with python3.13dist(requests-oauthlib) >= 1.3.1) python(abi) Provides -------- python3-garth: python-garth python3-garth python3.13-garth python3.13dist(garth) python3dist(garth) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2295121 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: PHP, C/C++, R, Java, Perl, SugarActivity, Ocaml, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2295121 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295121%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
