https://bugzilla.redhat.com/show_bug.cgi?id=2303812 --- Comment #3 from Tom.Rix@xxxxxxx --- Spec URL: https://trix.fedorapeople.org/amdsmi.spec SRPM URL: https://trix.fedorapeople.org/amdsmi-6.2.0-1.fc41.src.rpm For a refresh for review comments. I looked into packaging esmi_lib_library and added this comment to the spec file. # esmi_ib_library is not suitable for packaging # https://github.com/amd/esmi_ib_library/issues/13 # This tag was choosen by the amdsmi project because 4.0+ introduced variables not # found in the upstream kernel. I have moved the python bits into the main package. For %check. While the local copy of googletest isn't great. The tests themselves depend on having amd cpu and gpu install, so i do not think a bug is necessary for googletest, because even if this was fixed we would still have to run on hardware that exercised the code. I improved the comment. # Downloads its own googletest # Testing also depends on having AMD hardware cpu and/or gpu installed. # Not suitable for a general %check # # Non root result for gfx1100 and this kernel 6.11.0-0.rc2.23.fc41.x86_64 # 25 pass, 5 fail # No oops -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2303812 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303812%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
