https://bugzilla.redhat.com/show_bug.cgi?id=2302646 --- Comment #7 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- Thank you for taking the time to perform this review. Good to know Archlinux packages wolfssl. I may ping the package maintainer to learn why he chose the build options he did (since there are so many to choose from). Debian has wolfssl as well. They are using autotools, and UPDATED Spec URL: https://download.copr.fedorainfracloud.org/results/kni/wolfssl/fedora-rawhide-x86_64/07896744-wolfssl/wolfssl.spec UPDATED SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/wolfssl/fedora-rawhide-x86_64/07896744-wolfssl/wolfssl-5.7.0-1.fc41.src.rpm RESPONSES TO COMMENTS: License updated GPLv2 -> GPL-2.0-or-later 1)Directory ownership has been added: %dir %{_includedir}/wolfssl %{_includedir}/wolfssl/*.h %dir %{_includedir}/wolfssl/wolfcrypt %{_includedir}/wolfssl/wolfcrypt/*.h %dir %{_includedir}/wolfssl/openssl %{_includedir}/wolfssl/openssl/*.h I hope we can agree that all the other mentioned folders should NOT be owned by the wolfssl package. ;-) 2) %{isa} has been added to devel subpackage requires 3) The way the documentation is organized is by design. The example folder contains only .c code samples, and does not belong in the main package. Instead example folder and its contents have been bundled with -devel. The main package has just these files under doc: /usr/share/doc/wolfssl/ChangeLog.md /usr/share/doc/wolfssl/QUIC.md /usr/share/doc/wolfssl/README /usr/share/doc/wolfssl/README.md /usr/share/doc/wolfssl/README.txt /usr/share/doc/wolfssl/taoCert.txt Essentially, the changelog, README's containing notes about the project and a url to the online documentation, and instructions on how to make a cert The doc subpackage has been defined as an HTML doc subpackage. This is identified as such in the subpackage description. This is extra documentation, generated by make dox-html. Due to its large size, it made sense to put this into its own subpackage. However, one could perhaps argue the html documentation isn't not really needed at all, since the README points one to the online documentation. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2302646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202302646%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
