https://bugzilla.redhat.com/show_bug.cgi?id=2299981 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Peter Lemenkov from comment #3) > (In reply to Jerry James from comment #2) > > - Under "SHOULD items" below, "Patches link to upstream bugs/comments/lists > > or are otherwise justified" has not been done. > > All these three packages are Fedora-specific. I'll explain: Sure, I could tell what the patches do by looking at them. I was just asking if you are willing to add comments in the spec file with these explanations so Random Packager can tell what they do. This is a SHOULD, not a MUST, so I will not block on the review on it, but please consider adding such explanations. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2299981 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299981%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
