https://bugzilla.redhat.com/show_bug.cgi?id=2299981 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > Just a few minor items, most of which are nonblocking for this review: > > - There is no point in passing the -t flag to %pyproject_buildrequires if > the tests cannot be run anyway Done. I'll return it back as soon as all builddeps required for testing will be available. > - If you don't need this package on i386, it would be nice to add > "ExcludeArch: %{ix86}". See > https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval I do not need it on i386 but the package is noarch anyway so I'd rather not add an extra line to a spec-file. > - Under "SHOULD items" below, "Patches link to upstream bugs/comments/lists > or are otherwise justified" has not been done. All these three packages are Fedora-specific. I'll explain: * Patch1: vyper-0001-Use-Cryptodomex.patch ^^^ We package Cryptodomex with Cryptodome prefix. I'll try to propose upstream a compatible solution. * Patch2: vyper-0002-Ease-version-requirements.patch ^^^ Fedora sometimes has too modern libraries versions and upstream is too conservative to consider relaxing requirements. * Patch3: vyper-0003-Lark-should-go-to-the-main-install-section-as-it-use.patch ^^^ This was rejected by upstream and necessary only for %pyproject_check_import passing. > - Please see the non-executable-script warning below. Should that file be > executable? Done. The same links: Spec URL: https://peter.fedorapeople.org/packages/vyper.spec SRPM URL: https://peter.fedorapeople.org/packages/vyper-0.4.0-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2299981 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299981%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
