https://bugzilla.redhat.com/show_bug.cgi?id=2302515 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Kyle Gospodnetich from comment #1) > Hi there, this is an "unofficial" review as I am not yet a Fedora packager. Thank you! > Your spec file URL and SRPM URL have a typo, correct URLs appear to be: > https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch. > spec > https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch- > 0.3.0-1.fc40.src.rpm Agreed, and thank you for the correction. Spec URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch.spec SRPM URL: https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch-0.3.0-1.fc40.src.rpm > I attempted to build this locally however even with the @copr/PyPI repo > enabled this fails due to the following missing packages: > python3dist(azure-batch) > python3dist(azure-identity) > python3dist(azure-storage-blob) > > If these are also being requested can you link them here? Fedora packages are normally reviewed for Rawhide, and this is the default for the very helpful fedora-review tool (https://pagure.io/FedoraReview). In this case, the necessary dependencies are only available in Rawhide/F41 – they are present in F40 and F39, but the versions are too old. This package will therefore be for F41 and later. Try this: $ fedora-review -b 2302515 Note that fedora-review is extremely useful, bit it does have some bugs and outdated advice, so you still need to use your own judgement and refer to the Packaging Guidelines as the authoritative description of how things should be done. For a simple build without additional review-related checking, this works: $ mock -r fedora-rawhide-x86_64 --rebuild ./python-snakemake-executor-plugin-azure-batch-0.3.0-1.fc40.src.rpm > > Outside of that, your spec file looks good to me. I am curious about the > tests requiring Azure credentials. Is there no way that can be worked around > for offline builds? I am not aware of anything that can mock the Azure cloud infrastructure, no. For AWS there is https://pypi.org/project/moto/ , but it’s still not packaged for Fedora due to its very extensive tree of dependencies, and it’s also not necessarily trivial to “plug in” moto downstream if upstream hasn’t already integrated it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2302515 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202302515%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
