https://bugzilla.redhat.com/show_bug.cgi?id=2302515 Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |me@xxxxxxxxxxxxxxxxx --- Comment #1 from Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx> --- Hi there, this is an "unofficial" review as I am not yet a Fedora packager. Your spec file URL and SRPM URL have a typo, correct URLs appear to be: https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch.spec https://music.fedorapeople.org/python-snakemake-executor-plugin-azure-batch-0.3.0-1.fc40.src.rpm I attempted to build this locally however even with the @copr/PyPI repo enabled this fails due to the following missing packages: python3dist(azure-batch) python3dist(azure-identity) python3dist(azure-storage-blob) If these are also being requested can you link them here? Outside of that, your spec file looks good to me. I am curious about the tests requiring Azure credentials. Is there no way that can be worked around for offline builds? Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2302515 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202302515%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
