https://bugzilla.redhat.com/show_bug.cgi?id=2297995 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Are you sure that this package does what you want? The built "libpanel" subpackage will clash with the actual "libpanel", and it only contains an executable called "main". I appreciate that the license stuff is almost handled correctly (the license tag of the subpackage is incomplete), but did you stop to think whether this subpackage / executable should be included at all? It looks like the "main" binary is just an example application: ``` [[bin]] name = "main" path = "./examples/basic/main.rs" ``` This is unusual, examples are supposed to be [[example]] targets, not [[bin]] targets. It's why this is picked up as an installable executable when it probably shouldn't be. As-is, this is not acceptable due to the clash on package name with the actual "libpanel", and due to the incomplete license tag. I would strongly suggest to use ``` [package] cargo-install-bin = false ``` in a rust2rpm.toml config file to prevent installation of this example application and possibly report to upstream that example code is supposed to be an "example" and not an installable "bin". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2297995 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297995%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
