[Bug 2266044] Review Request: ghc-crypton - Cryptography Primitives sink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2266044

Peter Lemenkov <lemenkov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #12 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to Jens Petersen from comment #11)
> Thank you, Peter, for looking at the package.
> 
> > Looks good to me except for a thing that the upstream released version 1.0.0 recently while you still have 0.34 packaged. 
> > I guess this has something with API/ABI.
> 
> Right in Fedora we are tracking Stackage.org LTS which is still on this
> previous version.
> 1.0+ will likely go into Fedora 42 (via a newer Stackage major release) -
> I think it contains breaking API changes.
> 
> > Also another thins is a noisy rpmlnt (see below). Please comment what's going on?
> 
> Right unfortunately the rpmlint errors are a known issue, which I have
> reported to ghc upstream: basically the GHC toolchain is a bit different
> to the mainstream and it is non-trivial to fix this, also there is no real
> impact - things actually work fine: so we have been waiving these
> for a while.
> 
> The undefined-non-weak-symbol error is mentioned in the Haskell Packaging
> Guidelines
> <https://docs.fedoraproject.org/en-US/packaging-guidelines/Haskell/
> #_shared_and_static_library_linking>.
> I should get unused-direct-shlib-dependency added too, though it sounds less
> serious maybe.
> The upstream issue tracker is
> <https://gitlab.haskell.org/ghc/ghc/-/issues/17157>.
> It is annoying though since these keep coming up in these reviews:
> perhaps rpmlint could be made to ignore them for Haskell for now.


Ok, looks good to me then.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2266044

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202266044%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux